Centralize Unbounded configuration equality and STUN normalization

[myleshorton]

Move effective donor configuration equality and STUN normalization into Common, alongside UnboundedConfig and its fallback pool. Radiance can use UnboundedConfig.Equal to decide when to restart and NormalizeDonorSTUNServers when constructing the worker's STUN sampler.

Equality compares all configuration fields, treats STUN ordering, duplicates, and surrounding whitespace as insignificant, and treats empty pools as the default pool. Nil configurations equal only nil configurations. Normalization returns an independent slice without modifying its input.

Companion: getlantern/radiance#634. Based on atavism/usermessage, where #33 merged.

Validation: go test ./... -timeout=90s, including each config field, nil handling, equivalent pools, fallback behavior, and slice isolation.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 46db12cd-f529-45cb-9355-e62a6d4a493a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟢 Approval recommended

No unresolved review issues remain.

Pull request overview

Centralizes UnboundedConfig equality and STUN normalization in Common.

Changes:

• Adds nil-safe equality with normalized STUN pools.
• Adds sorting, deduplication, trimming, and fallback handling.
• Adds comprehensive tests, including slice isolation.

File summaries

File	Description
types.go	Implements configuration equality and STUN normalization.
types_test.go	Tests equality, fallback behavior, normalization, and slice isolation.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.