Repository navigation
fix(preview): backport source-loading scrub playback fix - #1614
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
5 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport the two bugfix/test commits from #1613 onto frozen
release/v2.3.0. A ruler scrub into another media file can stop at pointerup while the replacement decoder is loading; implicit seeks now retain the queued play intent, and later seeks wait for metadata before resuming.Only four preview/shell source/test files change. No feature, dependency, workflow, native helper or version change. The published RC6 assets/tag remain untouched. Source PR #1613 is merged on main (
ce55b76c9) with green CI and independent review PASS. Publication of a new candidate is a separate owner decision.Related issue
Refs #1597, #1613.
Type of change
Release impact
Desktop impact
Testing
a4641a0b7plus these same changes passes build-vite; the runtime patch ID isecc90aba7c7c43d267946492a23cba2169485d4e, matching the main fix. The entire tracked QA source tree equals this backport's tree061c2b1e955c3a5b7ac6667856ed79e601fba99e.