Skip to content

fix(preview): backport source-loading scrub playback fix - #1614

Merged
EtienneLescot merged 2 commits into
release/v2.3.0from
codex/v230-rc7-seek-fix
Nov 17, 2026
Merged

EtienneLescot merged 2 commits into
release/v2.3.0from
codex/v230-rc7-seek-fix

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

Backport the two bugfix/test commits from #1613 onto frozen release/v2.3.0. A ruler scrub into another media file can stop at pointerup while the replacement decoder is loading; implicit seeks now retain the queued play intent, and later seeks wait for metadata before resuming.

Only four preview/shell source/test files change. No feature, dependency, workflow, native helper or version change. The published RC6 assets/tag remain untouched. Source PR #1613 is merged on main (ce55b76c9) with green CI and independent review PASS. Publication of a new candidate is a separate owner decision.

Related issue

Refs #1597, #1613.

Type of change

  • Bug fix

Release impact

  • Patch

Desktop impact

  • Windows
  • macOS
  • Linux

Testing

  • Main fix: 104 targeted preview/shell tests pass, both TypeScript configurations, lint and build pass. Red/green cases cover repeated source-loading scrubs, initial pause and explicit cancellation after an intervening seek.
  • A renderer built from exact tag a4641a0b7 plus these same changes passes build-vite; the runtime patch ID is ecc90aba7c7c43d267946492a23cba2169485d4e, matching the main fix. The entire tracked QA source tree equals this backport's tree 061c2b1e955c3a5b7ac6667856ed79e601fba99e.
  • Final native Windows and Vivo controls pass: playing clicks in both directions, rapid cross-file drag and initially paused seek. Windows reproduces the earlier269ms failing drag successfully in263ms; full149-file payload verification finds only the expected private ASAR change and24 identical natives. Vivo keeps the public AppImage/native set unchanged. The Mac external-renderer QA route could not load a renderer and is explicitly skipped, pending a signed candidate; no bundle/security bypass.
  • Backport CI supplies the full suite against the frozen branch. No full checklist rerun: observed unaffected RC5/RC6 validations are retained with their provenance, following the maintainer's requested delta scope.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d89f741a-bd00-4525-8a30-6528896c2d38

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@EtienneLescot
EtienneLescot merged commit 28888e5 into release/v2.3.0 Nov 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant