Repository navigation
Conversation
box.sh and devconfig.sh call yq_resolve_bin directly, which still ran `go build` and failed on jobs without Go. Return early when yq_wrapper will run gojq instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFMJB4czsR4Tgad5w9cGrM
…t go Also drop a comment that repeated the function header. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFMJB4czsR4Tgad5w9cGrM
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFMJB4czsR4Tgad5w9cGrM
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFMJB4czsR4Tgad5w9cGrM
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HFMJB4czsR4Tgad5w9cGrM
malept
marked this pull request as ready for review
October 23, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Follow-up to getoutreach/devbase#1252, which added a
gojqfallback toyq_wrapperandshell/yq.shfor jobs without Go.shell/lib/box.shandshell/devconfig.shcallyq_resolve_bindirectly, and it still rango buildon an unstable devbase version. Jobs without Go, which for example ranci/release/docker-authn.shas one of the steps, failed with "failed to build devbase".yq_resolve_binnow returns early whenyq_wrapperwill rungojqinstead.Notes for your reviewers
Tagged releases are unaffected: they use a downloaded binary, and a test covers a tagged version without Go. Without Go,
yq_resolve_bincaches nothing, so eachyq_wrappercall repeats the cheapyq_use_gojqcheck.The fallback is silent. A warning when it runs
gojqwould be noisy while many callers still runshell/yq.shas a separate process. It can be added inyq_run_gojqonce those calls move toyq_wrapper.Rejected review findings
These findings were reviewed and rejected. Do not raise them again unless the code changes in a way that affects them.
yq_use_gojqruns twice peryq_wrappercall, and the version lookup repeats. The check is a file read and acommand -v. Sharing the result needs a larger redesign for little gain.gojqdecision is made inshell/yq.sh,yq_wrapperandyq_resolve_bin; use a single resolver. A single resolver is a reasonable refactor but out of scope for this fix.yq_wrappertest stubsyq_resolve_binto fail, so it is redundant. It still shows thatyq_wrapperreturns before it resolves.yq_resolve_binlocal/dev test needs afind_toolstub. The stub keeps the test from depending on whether Go is installed.find_tool gocan find a mise-managed Go that is not onPATH, while the build runs a barego. Mise-managed Go will be onPATH, so the check and the build agree.find_tool gojqcan print "mise not found" to stderr. Afatalerror follows it, so the message is not extra noise.Generated by Claude Code