Repository navigation
Conversation
@graphql-eslint's no-hashtag-description ignores a comment whose text starts with "eslint", so a directive such as "# eslint-disable ..." above a definition is not reported. The devbase port treated it as a description and flagged it, which made the rule report violations that the ESLint rule it replaces does not. Skip the last comment before a definition when its text starts with "eslint", matching the ESLint rule. Assisted-By: claude-sonnet 5.5 via opencode
malept
added this pull request to stack #1261
October 24, 2026 00:22
Contributor
|
Link to code coverage report (posted by coverbot 🤖) |
malept
marked this pull request as ready for review
October 24, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
no-hashtag-descriptionreports a#comment placed directly above a definition as a description written the wrong way. That includes# eslint-disable ...directives, which the@graphql-eslintrule skips. The devbase port flagged them, so schemas that pass ESLint failed here.Skip the comment when its text starts with
eslint, as the ESLint rule does.Jira ID
DT-5641
Notes for your reviewers
The test that expected
# eslint-disable-next-lineto be flagged is now a valid case. It had been inverted from the upstream suite because devbase had no suppression syntax at the time. Honoring the directives themselves is a separate change.Rejected review findings and intentional non-goals
These were raised in earlier reviews and deliberately left as they are. Do not raise them again unless the reasoning below no longer holds.
Rejected findings
isEslintDirectivetoisESLintDirective. Every identifier in this package that mentions ESLint uses lowercaseeslint, so a single capitalized name would be inconsistent.Intentional behavior
eslint, as the upstream rule does.eslintcomments here. Acting on the directives is a separate change.