[aldy505]

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[github-actions]

Changelog Preview

This PR lands in these workspaces:

• objectstore-server: CalVer

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

---

New Features

• Generic garbage collector by aldy505 in #747

---

_{🤖 This preview updates automatically when you update the PR.}

[codecov]

Codecov Report

❌ Patch coverage is 97.89474% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.59%. Comparing base (1fe4d59) to head (aaad2fb).

Files with missing lines	Patch %	Lines
objectstore-service/src/change_stream/gc.rs	97.89%	2 Missing ⚠️

Additional details and impacted files

@@                                   Coverage Diff                                   @@
##           aldy505/feat/change-stream/sqlite-garbage-collector     #747      +/-   ##
=======================================================================================
+ Coverage                                                91.57%   91.59%   +0.01%     
=======================================================================================
  Files                                                      117      118       +1     
  Lines                                                    22383    22478      +95     
=======================================================================================
+ Hits                                                     20498    20588      +90     
- Misses                                                    1885     1890       +5     

Components	Coverage Δ
Rust Backend	94.73% <97.89%> (+0.01%)	⬆️
Rust Client	84.41% <ø> (ø)
Python Client	93.88% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit aaad2fb. Configure here.}

[cursor]

Delete can drop in-flight writes

Medium Severity

commit_delete removes the GC index entry with no sequencing against an in-flight write. A concurrent begin_write can record a deadline, then commit_delete can drop it, after which the write still succeeds. Because commit_write is a no-op, that object is never re-indexed and will not be collected.

Additional Locations (1)

• objectstore-service/src/change_stream/gc.rs#L40-L47

 

^{Reviewed by Cursor Bugbot for commit aaad2fb. Configure here.}

[aldy505]

I think this behavior is acceptable. Should we guard the begin_write expiry time to be more than some seconds?