Repository navigation
fix: stringify numeric list values in query_param_matcher - #827
Closed
Shubham-Padkonde wants to merge 1 commit into
Closed
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
query_param_matcher converted top-level int/float values to str to match
what requests sends, but left numbers inside list values untouched, so
query_param_matcher({"ids": [1, 2]}) never matched a request made with
params={"ids": [1, 2]} (request.params is {"ids": ["1", "2"]}).
Member
|
Duplicate of #816 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
query_param_matcher converted top-level int/float values to str to match what requests sends, but left numbers inside list values untouched, so query_param_matcher({"ids": [1, 2]}) never matched a request made with params={"ids": [1, 2]} (request.params is {"ids": ["1", "2"]}).
What type of PR is this? (check all applicable)
Description
Related Issues
PR checklist
Before submitting this pull request, I have done the following:
toxandpre-commitchecks locallyAdded/updated tests?