Repository navigation
Generator/iterator request bodies are never consumed, even after a successful mocked call - #840
Open
juneja-varun wants to merge 2 commits into
Open
juneja-varun wants to merge 2 commits into
juneja-varun wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit da32f59. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #713.
I upload large files in chunks via a generator (
while f.tell() < file_size: requests.post(url, data=chunk_file(f, ...))), and underresponsesthis loop never terminates - the file position never advances, because the generator passed asdata=is never actually read. A real network send would consume it chunk by chunk while writing to the socket;responsesjust stores the generator object as-is inrequest.bodyand moves on.This is the same class of gap as #719/#736 (file-like objects with
.read()weren't being consumed either, fixed by reading them in_read_filelike_body) - just for the other kind of streaming bodyrequestssupports. Extended that same helper to drain a generic iterator/generator into bytes too.(The original issue's title points at
multipart_matcher, but that's not actually the site of the bug -files=uploads get fully read byrequestsitself duringprepare_body(), beforeresponsesever sees them. The real gap is in the general streamed-data=path, which is what the fix targets.)