docs(solidstart): Document the SolidStart 2 setup - #19376
Draft
JPeer264 wants to merge 1 commit into
Draft
Conversation
`npm install @solidjs/start` gives SolidStart 2 today, and the guide described SolidStart 1 only. On SolidStart 2 there is no `app.config.ts`, `@solidjs/start/config` exports no `defineConfig`, the build emits no `.output/server/instrument.server.mjs`, and vinxi is not installed, so the documented config was ignored and the documented start command exited with `ERR_MODULE_NOT_FOUND`. Give each affected step a SolidStart 2 tab next to the SolidStart 1 one: - Server init moves to a Nitro startup plugin, `server/plugins/sentry.ts`. - The build config moves to `vite.config.ts` with `sentrySolidStart` from `@sentry/solidstart/vite`. - The server starts with a plain `node .output/server/index.mjs`. The Vite plugin instruments dependencies at build time, so no preload is needed. - Source map options move into `sentrySolidStart()`. Add a SolidStart prerequisites include naming the supported versions, so readers know which set of tabs applies to them. The guide fell back to the default include, which names no framework version at all. Scope the `--import`, limited server tracing and dynamic import installation methods to SolidStart 1, since all three configure `withSentry` in `app.config.ts`. Import `sentryBeforeResponseMiddleware` from `@sentry/solidstart`. The package exports `.`, `./solidrouter` and `./vite`, so the documented `@sentry/solidstart/middleware` path failed with `ERR_PACKAGE_PATH_NOT_EXPORTED`. Refs SDK-1515 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
the
Priority: Needs Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
closes SDK-1515
npm install @solidjs/startgives SolidStart 2 today, and the guide described SolidStart 1 only. On SolidStart 2 there is noapp.config.ts,@solidjs/start/configexports nodefineConfig, the build emits no.output/server/instrument.server.mjs, and vinxi is not installed, so the documented config was ignored and the documented start command exited withERR_MODULE_NOT_FOUND.Give each affected step a SolidStart 2 tab next to the SolidStart 1 one:
server/plugins/sentry.ts.vite.config.tswithsentrySolidStartfrom@sentry/solidstart/vite.node .output/server/index.mjs. The Vite plugin instruments dependencies at build time, so no preload is needed.sentrySolidStart().Add a SolidStart prerequisites include naming the supported versions, so readers know which set of tabs applies to them. The guide fell back to the default include, which names no framework version at all.
Scope the
--import, limited server tracing and dynamic import installation methods to SolidStart 1, since all three configurewithSentryinapp.config.ts.Import
sentryBeforeResponseMiddlewarefrom@sentry/solidstart. The package exports.,./solidrouterand./vite, so the documented@sentry/solidstart/middlewarepath failed withERR_PACKAGE_PATH_NOT_EXPORTED.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES