Skip to content

feat(pii): add data processors that are shared within framework SDKs - #2195

Open
Litarnus wants to merge 4 commits into
request-data-collectionfrom
shared-data-collectors
Open

feat(pii): add data processors that are shared within framework SDKs#2195
Litarnus wants to merge 4 commits into
request-data-collectionfrom
shared-data-collectors

Conversation

@Litarnus

@Litarnus Litarnus commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Provides classes for HTTP data extraction which can be used in Symfony/Laravel without having to write them per SDK

Comment thread src/DataCollection/HttpDataCollector.php

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 16ded29. Configure here.

$body = $request->getParsedBody();
if ($body !== null) {
return self::collect($options, 'incomingRequest', $body);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty parsed body skips stream

High Severity

collectServerRequest treats any non-null getParsedBody() result as the full body, including an empty array, and never reads the request stream. The default RequestFetcher builds requests with ServerRequest::fromGlobals(), which always sets the parsed body to $_POST. JSON and other non-form payloads leave $_POST empty, so those bodies are dropped and events can receive data: [] instead, including on GET requests.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 16ded29. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant