Skip to content

chore: Remove trace template, trace_ignore_status_codes - #7457

Merged
sentrivana merged 12 commits into
major/3.0from
ivana/major/fix-tests-4
Sep 10, 2026
Merged

chore: Remove trace template, trace_ignore_status_codes#7457
sentrivana merged 12 commits into
major/3.0from
ivana/major/fix-tests-4

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 10, 2026

Copy link
Copy Markdown
Contributor
  • trace_ignore_status_codes implies tail-based sampling, which we don't do
  • remove @trace templates
    • removed this from the old @trace decorator, which cascaded to a lot of helper functions etc.
    • the old @trace decorator will be removed completely with old tracing later

Base automatically changed from ivana/major/fix-tests-3 to major/3.0 September 10, 2026 08:50
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

69679 passed | ⏭️ 3315 skipped | Total: 72994 | Pass Rate: 95.46% | Execution Time: 216m 16s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -65972
Passed Tests 📉 -62156
Failed Tests
Skipped Tests 📉 -3816

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2311 uncovered lines.
❌ Project coverage is 89.76%. Comparing base (436e0e5) to head (b358be7).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.17%    89.76%    -0.41%
==========================================
  Files          193       185        -8
  Lines        25790     22569     -3221
  Branches      9532      8168     -1364
==========================================
+ Hits         23256     20258     -2998
- Misses        2534      2311      -223
- Partials      1434      1323      -111

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review September 10, 2026 09:06
@sentrivana
sentrivana requested a review from a team as a code owner September 10, 2026 09:06

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ded1917. Configure here.

Comment thread sentry_sdk/tracing_utils.py
@sentrivana
sentrivana merged commit e9b6185 into major/3.0 Sep 10, 2026
147 checks passed
@sentrivana
sentrivana deleted the ivana/major/fix-tests-4 branch September 10, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants