chore(deps): update Native SDK to v0.16.8 - #2860
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
bruno-garcia
force-pushed
the
deps/modules/sentry-native/0.16.8
branch
from
September 19, 2026 07:22
684474d to
1322b34
Compare
| @@ -1 +1 @@ | |||
| Subproject commit 672b86c77c1864e1c0b5e72eefadc078e30ef700 | |||
| Subproject commit d5677deb89ae24c14821f4217e50100f96bca3c7 | |||
There was a problem hiding this comment.
Bug: The C# code unconditionally calls the native function sentry_options_set_enable_logs, which was removed in the updated sentry-native submodule, silently disabling native crash reporting.
Severity: CRITICAL
Suggested Fix
The P/Invoke call to sentry_options_set_enable_logs and its declaration in SentryNativeBridge.cs should be removed, as the underlying native function no longer exists. The feature it controlled was a no-op in recent versions anyway.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: modules/sentry-native#L1
Potential issue: The `sentry-native` submodule was updated, which removed the exported
function `sentry_options_set_enable_logs`. However, the C# code in
`SentryNativeBridge.cs` still attempts to call this function via P/Invoke. This will
cause an `EntryPointNotFoundException` at runtime. While a `try-catch` block in
`SentryNative.Configure()` prevents an application crash, it also silently disables
native crash reporting on all supported platforms (Windows, macOS, Linux, iOS, and
Android). This means users will believe native crash reporting is active when it is not,
leading to a loss of critical crash data.
Did we get this right? 👍 / 👎 to inform future reviews.
Collaborator
|
Superceded by #2862 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps modules/sentry-native from 0.16.6 to 0.16.8.
Auto-generated by a dependency updater.
Changelog
0.16.8
Features:
sentry_options_set_initial_scopefor configuring scope data before the crash backend is started, including out-of-process crash handlers. (#2087)Fixes:
Thank you:
0.16.7
Important:
This version was accidentally released from
masterand includes breaking changes intended for0.17. It is superseded by0.16.8, which restores compatibility with0.16.6and includes the intended hotfixes.See https://github.com/getsentry/sentry-native/releases/tag/0.16.7 for the original changelog.