feat(event formatter): list every thread, with state and frame counts - #124206
Draft
shayna-ch wants to merge 1 commit into
Draft
feat(event formatter): list every thread, with state and frame counts#124206shayna-ch wants to merge 1 commit into
shayna-ch wants to merge 1 commit into
Conversation
The section skipped any thread without a stacktrace, never rendered state, and gave no frame counts. On a mobile crash that is the worst case: a 39 thread Unreal crash rendered as a few stacktraces with the crashed thread missing entirely, because it had zero frames. Lists every thread now with its id, state, flags and frame count, which is what the MCP's own thread table carries. Splits the count cap in two: max_threads_listed bounds the listing, max_thread_stacktraces bounds how many carry a stacktrace, since the stacktraces are what cost. The old max_threads did both jobs at 8 and so had to drop threads to stay small. Flags replace the Crashed field, matching the MCP, which also surfaces `current`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The section skipped any thread without a stacktrace, never rendered state, and gave no frame counts. On a mobile crash that is the worst case: a 39 thread Unreal crash rendered as a few stacktraces with the crashed thread missing entirely, because it had zero frames.
Lists every thread now with its id, state, flags and frame count, which is what the MCP's own thread table carries. Splits the count cap in two: max_threads_listed bounds the listing, max_thread_stacktraces bounds how many carry a stacktrace, since the stacktraces are what cost. The old max_threads did both jobs at 8 and so had to drop threads to stay small.
Flags replace the Crashed field, matching the MCP, which also surfaces
current.