Repository navigation
fix: approvals after a refused mode switch, and compaction with a queued message - #179
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
…ction Co-Authored-By: Claude <noreply@anthropic.com>
ggfincke
changed the title
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #178 found by review bots on the upstream PRs. Leaving Plan in Auto on a model without Auto, or restoring a Plan Claude entered itself, could fall back to default while turns kept Auto's policy, which has no approval callback, so requests default forwards for approval were allowed without asking; each turn now uses the mode Claude accepted, with the approval callback on when that differs from the requested mode, which also covers the CLI's own launch-time fallback after the first turn. Separately, web's compact-before-send gate took the latest unheld run, so a queued message could hide background work from the run before it; it now uses a provider-only check that skips queued runs and treats a rolled-back latest run like idle compaction does. Tests cover both approval paths and the compaction cases. Done by Claude Opus 5.5 in Claude Code (via 456code).