Repository navigation
fix: strip space padding from the structured order code - #949
Merged
Merged
Conversation
The S7-1200/1500 order code field is space padded, and only NUL bytes were stripped, so get_order_code returned "6ES7 212-1BE40-0XB0 " with a trailing space. The flat S7-300 parser already strips both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The S7-1200/1500 order code field in SZL 0x0011 is space padded, and only NUL bytes were stripped, so
get_order_codereturned6ES7 212-1BE40-0XB0with a trailing space. The flat S7-300 parser already strips both. Reported in #919.