Repository navigation
Conversation
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clickis listed as the optionalcliextra, but thes7console script is always installed. On a plainpip install python-snap7, runnings7fails with anImportErrortraceback fromsnap7.cli. Downstream packagers, such as the conda-forge recipe being added, then have to makeclicka hard dependency to keep the installed script working.This points the
s7entry point at a small wrapper,snap7._console:main. The wrapper checks forclickbefore importingsnap7.cli:click,s7printsInstall them with: pip install python-snap7[cli]to stderr and exits with status 1.click, behaviour is unchanged.snap7.cliitself is unchanged, sofrom snap7.cli import mainandpython -m snap7.cliwork as before.Testing
tests/test_console.pycovers both paths:clickmissing, andclickpresent.pip install .(noclick):s7 --helpprints the hint and exits 1. With[cli]installed it shows the normal help.uv run pre-commit run --all-filespasses, including mypy and ruff.pytest -m "server or util or client or mainloop": all pass excepttest_get_pg_block_info. That test also fails on unmodifiedmasterwhen run in a US timezone (b'2019/06/26' != b'2019/06/27') and passes withTZ=UTC, so it is unrelated to this change.