Repository navigation
fix: prevent denied jobs from bypassing policy via retry - #249
Merged
Merged
Conversation
# Conflicts: # src/github_agent_bridge/dashboard_static/assets/index-DBHrKV9X.js # src/github_agent_bridge/dashboard_static/index.html
giscebot
approved these changes
Oct 6, 2026
giscebot
left a comment
Collaborator
There was a problem hiding this comment.
Approved. I checked the retry transition end to end: the queue now enforces blocked plus auto_trusted atomically, so both API and CLI callers reject denied and approval-pending jobs; the dashboard keeps Dismiss available while hiding Retry; operations documentation matches the behavior. The branch contains current main and remains MERGEABLE/CLEAN. Local verification on the reviewed commit: pytest 436 passed, dashboard 64 passed, production build succeeded and reproduced the committed static bundle, and git diff --check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard/API retry path requeued
deniedandwaiting_approvaljobs directly topending, bypassing the policy decision recorded when the job was created. A deniedworkflow_runcould therefore be dispatched by an admin retry.Fix
blockedjobs whose recorded decision is executable (auto_trusted). This guards both API and CLI callers atomically.Verification
pytest -q(full suite)npm --prefix dashboard test -- --runnpm --prefix dashboard run buildThis does not re-evaluate a blocked job against a policy changed after initial enqueue; that is a separate follow-up guardrail.