Skip to content

fix: keep review requests read-only - #254

Merged
ecarreras merged 1 commit into
mainfrom
fix/reviews-always-read-only
Oct 6, 2026
Merged

ecarreras merged 1 commit into
mainfrom
fix/reviews-always-read-only

Conversation

@giscebot

@giscebot giscebot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • force every submit_review job to use review_only after classification
  • prevent later intent updates from elevating review jobs to work_allowed
  • cover the real fix(deps): ... title regression and post-enqueue reclassification

Validation

  • pytest -q tests/test_webhook.py::test_webhook_canary_enqueues_pull_request_review_requested_for_configured_bot tests/test_queue.py::test_submit_review_intent_cannot_be_elevated_after_enqueue

TASK-85718

Requested by: @ecarreras

Co-authored-by: Eduard Carreras <ecarreras@gisce.net>
@giscebot giscebot self-assigned this Oct 6, 2026
@giscebot
giscebot requested a review from ecarreras October 6, 2026 07:47
@ecarreras
ecarreras merged commit 52ca9ac into main Oct 6, 2026
3 checks passed
@ecarreras
ecarreras deleted the fix/reviews-always-read-only branch October 6, 2026 14:33
@giscebot

giscebot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

Post-merge verification completed on current origin/main at bda03c4 (which contains merge commit 52ca9ac):

  • regression tests for webhook review-request ingestion and post-enqueue intent elevation: 2 passed
  • full test suite: 439 passed

No follow-up patch is needed. The submit_review read-only guardrail is integrated and the review-request item is resolved by the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants