Fix show total when total domain is not set - #39
Merged
Merged
Conversation
- Add showTotal attribute to GraphIndicator class - showTotal defaults to True only when totalDomain is defined, otherwise False - Always include showTotal in response with correct boolean value - Add comprehensive tests for showTotal functionality in both graph_spec.py and processor_spec.py - Ensure logical behavior: only show total when totalDomain exists
ecarreras
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for the
showTotalproperty in indicator graphs so that it defaults toTrueonly when atotalDomainis defined, and toFalseotherwise. The changes ensure consistent behavior and update the corresponding tests to reflect this new default.Logic changes
showTotalinooui/graph/indicator.pyto beTrueonly iftotalDomainis defined, otherwiseFalse. Previously, it always defaulted toTrueregardless oftotalDomain.Test updates
spec/graph/graph_spec.pyto expectshowTotalto beFalsewhentotalDomainis not present, andTruewhen it is present. Added new test cases for both scenarios. [1] [2]showTotalin the response, and verify its value matches the new logic depending on the presence oftotalDomain.spec/graph/processor_spec.pyto expectshowTotal=FalsewhentotalDomainis not defined andshowTotal=Truewhen it is defined. [1] [2]