Remove allocations from SemVer scheme validation - #47
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
This PR makes SemVer validation allocation-free while preserving existing behavior.
Changes:
- Reuses
parseSemverValuefor validation. - Iterates prerelease and build identifiers without allocations.
- Adds compatibility tests, fuzzing, and benchmarks.
File summaries
| File | Description |
|---|---|
semver_validation_test.go |
Adds validation tests, fuzz coverage, and benchmarks. |
normalization.go |
Implements allocation-free SemVer-like validation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the existing SemVer parser and iterate suffix identifiers without allocating regex matches or split slices. This preserves validation behavior for npm, semver, Cargo, Go, Hex, and Elixir.
Validating
1.2.3drops from 192 bytes and two allocations to zero. Validation of prerelease and build identifiers also becomes allocation-free.