Avoid allocations in PyPI and Composer validation - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues block approval.
Pull request overview
This pull request optimizes PyPI and Composer version validation by replacing parsed-version allocations with direct regex checks while preserving existing behavior.
Changes:
- Uses direct PEP 440 regex matching for PyPI validation.
- Adds allocation-free Composer validation.
- Adds benchmarks, fuzz coverage, and regression tests.
File summaries
| File | Summary |
|---|---|
validation_bench_test.go |
Adds validation benchmarks and regression coverage. |
normalization.go |
Uses direct regex matching for PyPI validation. |
composer_pub.go |
Adds allocation-free Composer version validation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate PyPI and Composer versions without constructing parsed version components. Keep Composer's recognized stability labels and existing handling of branch versions and Unicode case folding.
For plain and prerelease versions passed through
purl.CleanVersion, this removes three allocations per call: about 401 bytes for PyPI and 176 bytes for Composer, both reduced to zero.