test(nat): skip slow Miri tests under emulation

[daniel-noland]

reduce miri runs

[coderabbitai]

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: a4905446-51ec-4e89-9b55-48f34f8ec041

📥 Commits

Reviewing files that changed from the base of the PR and between 9226f7b and cf1f33e.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 77d166c3-9e7a-454f-869f-fe6b035a48a7

📥 Commits

Reviewing files that changed from the base of the PR and between c824324 and 9226f7b.

📒 Files selected for processing (1)

• .github/workflows/dev.yml

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

---

📝 Walkthrough

Walkthrough

The PR adds emulation-specific skips to six masquerade and allocation tests. It also increases the configured core limit for three Miri workflow runs from 8 to 10.

Changes

Masquerade emulation handling

Layer / File(s)	Summary
Emulation-specific test skips nat/src/masquerade/apalloc/test_alloc.rs, nat/src/masquerade/test.rs	Six tests now skip under emulation because they are too slow. Tests retain their existing behavior outside emulation.

Miri resource configuration

Layer / File(s)	Summary
Miri core limits .github/workflows/dev.yml	The standard, permissive-provenance, and strict-provenance Miri runs increase their configured core limits from 8 to 10.

Priority: ⬇️ Low

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 77.78% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: skipping slow NAT Miri tests under emulation.
Description check	✅ Passed	The description states that the pull request reduces Miri runs, which matches the changeset and objectives.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 77.78% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (1 skipped: 1 unsupported.)

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[Copilot]

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Reduces emulated/Miri test runtime by skipping six slow NAT tests while preserving native execution.

Changes:

• Skips five masquerade tests under emulation.
• Skips one IPv6 allocator test under emulation.

File	Description
nat/​src/​masquerade/​test.rs	Skips five slow masquerade tests during emulation.
nat/​src/​masquerade/​apalloc/​test_alloc.rs	Skips one slow IPv6 allocator test during emulation.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.