UnboundList: Cache encode - #22659
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The cache-stage dependencies preserve semantics and consistently cover both current UnboundList instantiations.
Review effort: Balanced
Findings: None
What changed in this PR
Caches UnboundList element encoding to reduce evaluation time and DIL size, while assigning Rust consumers to the type-inference cache stage.
Changes:
- Marks
UnboundList.encodeas cached. - Associates Rust type-parameter and dereference IDs with
CachedStage.
| File | Description |
|---|---|
shared/util/codeql/util/UnboundList.qll |
Caches element encoding. |
rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll |
Stages type-parameter ID computation. |
rust/ql/lib/codeql/rust/internal/typeinference/DerefChain.qll |
Stages dereference-chain ID computation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCA reports a small speedup as well as a small reduction in DIL sizes.