Conversation
The original models referred to named arguments as positional arguments, based on the declaration order in the target method, and -1 for the receiver. Change this to Argument[name:] for named arguments, and Argument[self] for the receiver.
Sorting the argument labels simplifies matching with calls
We'll want to avoid importing internal files from queries so LegacyMad will have a "public" API though I expect it to be rewritten eventually.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+117
to
+132
| key = "Taint sources - active" and value = count(DataFlow::Node n | Models::isSource(n, "remote")) | ||
| or | ||
| key = "Taint sources - disabled" and | ||
| value = count(DataFlow::Node n | Models::isSource(n, any(string s | s != "remote"))) | ||
| or | ||
| key = "Taint sources - sensitive data" and none() | ||
| or | ||
| key = "Taint edges - number of edges" and none() | ||
| or | ||
| key = "Taint reach - nodes tainted" and none() | ||
| or | ||
| key = "Taint reach - total non-summary nodes" and none() | ||
| or | ||
| key = "Taint reach - per million nodes" and none() | ||
| or | ||
| key = "Taint sinks - query sinks" and value = count(DataFlow::Node n | Models::isSink(n, _)) |
Comment on lines
+117
to
+122
| key = "Taint sources - active" and value = count(DataFlow::Node n | Models::isSource(n, "remote")) | ||
| or | ||
| key = "Taint sources - disabled" and | ||
| value = count(DataFlow::Node n | Models::isSource(n, any(string s | s != "remote"))) | ||
| or | ||
| key = "Taint sources - sensitive data" and none() |
|
|
||
| from DataFlow::Node node, string kind | ||
| where Models::isSink(node, kind) | ||
| select node, "Sink of kind '" + kind + "'" |
|
|
||
| from DataFlow::Node node, string kind | ||
| where Models::isSource(node, kind) | ||
| select node, "Source of kind '" + kind + "'" |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.