Skip to content

Unified: Handle GenericTypeExpr in static name binding #22665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 3 commits into from
Sep 24, 2026
+15 −0
Merged

Unified: Handle GenericTypeExpr in static name binding #22665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdcc11b
Unified: Add static name binding for generic type expressions
hvitved Sep 23, 2026
009d0c3
Unified: Handle `GenericTypeExpr` in static name binding
hvitved Sep 23, 2026
d7ef672
Apply suggestion from @asgerf
hvitved Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions unified/ql/lib/codeql/unified/internal/StaticNameBinding.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ class NameBindingNode extends TNameBindingNode {
Identifier getIdentifierFromRef(AstNode n) {
result = n.(PotentialLocalNameAccess)
or
result = getIdentifierFromRef(n.(GenericTypeExpr).getBase())
or
result = n.(MemberAccessExpr).getMemberNameNode()
}

Expand Down
4 changes: 4 additions & 0 deletions unified/ql/test/library-tests/static-name-binding/CONSISTENCY/CfgConsistency.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
consistencyOverview
| deadEnd | 1 |
deadEnd
| generics.swift:3:10:3:17 | Entry |
9 changes: 9 additions & 0 deletions unified/ql/test/library-tests/static-name-binding/generics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
enum GenericEnum<T> {
case novalue
case value(T) // $ access=T
}

func testGenericEnum() {
let intValue = GenericEnum.value(42) // $ access=GenericEnum access=GenericEnum.value
let stringValue = GenericEnum<String>.novalue // $ access=GenericEnum access=String access=GenericEnum.novalue
}
Loading