Conversation
We don't use these, and have no immediate plans to do so either, so in the interest of cleaning things up, I'm getting rid of this now. We can always add them back later if necessary.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The hard-coded temporary identifier can collide with assignment targets and produce incorrect transformations.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Removes Yeast’s fresh-literal support from its API, macros, tests, and documentation.
Changes:
- Removes
FreshScopeand fresh-name plumbing. - Removes
$freshparsing and documentation. - Replaces generated test identifiers with fixed names.
| File | Summary |
|---|---|
shared/yeast/tests/test.rs |
Uses fixed temporary names. Critical: assignment_tmp is non-hygienic and can overwrite matched targets before later values are read (lines 799 and 827). |
shared/yeast/src/tree_builder.rs |
Removes fresh-name generation. |
shared/yeast/src/lib.rs |
Removes fresh-scope integration. |
shared/yeast/src/build.rs |
Removes fresh-scope state and APIs. |
shared/yeast/doc/yeast.md |
Removes fresh-literal documentation. |
shared/yeast-macros/src/parse.rs |
Removes fresh-literal parsing. |
shared/yeast-macros/src/lib.rs |
Updates macro documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't use these, and have no immediate plans to do so either, so in the interest of cleaning things up, I'm getting rid of this now. We can always add them back later if necessary.