Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The depth guard matches CFG indexing semantics, and the regression test covers the reported false positive.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Go CFG generation so direct field and method selections do not create invalid depth-zero implicit-field nodes, preventing false unreachable-statement alerts.
Changes:
- Restricts implicit selections to positive depths.
- Adds a regression test using recursive embedding.
| File | Description |
|---|---|
go/ql/lib/semmle/go/controlflow/ControlFlowGraphImpl.qll |
Excludes depth-zero implicit selections. |
go/ql/test/query-tests/RedundantCode/UnreachableStatement/main.go |
Tests reachability for a direct field on a recursively embedded type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where CFG nodes are made for implicit field selections with depth 0 when there is a recursive struct. This bug was introduced when migrating Go to the new shared CFG library. It caused FPs in go/unreachable-statement. A test has been added to demonstrate the bug and show that it is fixed.
This does not need a change note as it is fixing an FP that hasn't been in any release.