Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The existing direct CFG expected output must be updated for the removed exceptional edge.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes Go CFG handling so go calls do not terminate control flow in the caller.
Changes:
- Excludes goroutine calls from abrupt-completion modeling.
- Adds an unreachable-statement regression test.
| File | Description |
|---|---|
ControlFlowGraphImpl.qll |
Corrects CFG behavior for goroutine calls. |
UnreachableStatement/main.go |
Adds a go panic() regression case. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Ast::AstNode ast, PreControlFlowNode n, AbruptCompletion c, boolean always | ||
| ) { | ||
| ast instanceof Go::CallExpr and | ||
| not isGoStmtCall(ast) and |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private predicate notBlankIdent(Go::Expr e) { not e instanceof Go::BlankIdent } | ||
|
|
||
| /** Holds if `e` is invoked in a newly started goroutine. */ | ||
| private predicate isGoStmtCall(Ast::AstNode e) { e = any(Go::GoStmt s).getCall() } |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where control flow stops at
go panic(). This bug was introduced when migrating Go to the new shared CFG library. It caused FPs in go/unreachable-statement. A test has been added to demonstrate the bug and show that it is fixed.This does not need a change note as it is fixing an FP that hasn't been in any release.