Skip to content

Go: fix some FPs in go/whitespace-contradicts-precedence #22675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −0
Open

Go: fix some FPs in go/whitespace-contradicts-precedence #22675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
426bbfa
Add test with spurious result for go/whitespace-contradicts-precedence
owen-mc Sep 24, 2026
fe566f0
Fix test - ignore parenthesized operands
owen-mc Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/ql/src/InconsistentCode/WhitespaceContradictsPrecedence.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class HarmlessNestedExpr extends BinaryExpr {
*/
predicate interestingNesting(BinaryExpr inner, BinaryExpr outer) {
inner = outer.getAChildExpr() and
not isParenthesized(inner, _) and
not inner instanceof AssocNestedExpr and
not inner instanceof HarmlessNestedExpr
}
Expand Down
4 changes: 4 additions & 0 deletions ...est/query-tests/InconsistentCode/WhitespaceContradictsPrecedence/ParenthesizedOperands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ package main
func weightedMeanGood(a, b float64, countA, countB, total int) float64 {
return ((a * float64(countA)) + (b * float64(countB))) / float64(total)
}

func parenthesizedGood(a, b, c int) int {
return (a ^ b)&c
}
Loading