yeast: Remove support for repeating phases - #22676
Merged
Merged
Conversation
These were never used in practice (only in tests), and we don't foresee an immediate use for them. If necessary, we can always add them back later.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation, integrations, tests, and documentation consistently adopt the simplified translation semantics.
Review effort: Balanced
Findings: None
What changed in this PR
Removes YEAST repeating phases, standardizing all phases on exhaustive one-shot translation.
Changes:
- Simplifies phase, rule, runner, and translator APIs.
- Updates Swift integration and YEAST tests.
- Revises macro documentation and user guidance.
| File | Description |
|---|---|
unified/extractor/src/languages/swift/swift.rs |
Adopts simplified phase API. |
shared/yeast/tests/test.rs |
Updates tests for exhaustive translation. |
shared/yeast/src/lib.rs |
Removes repeating-phase implementation and APIs. |
shared/yeast/src/build.rs |
Updates translation documentation. |
shared/yeast/doc/yeast.md |
Documents one-shot phase semantics. |
shared/yeast-macros/src/parse.rs |
Removes repeating-rule references. |
shared/yeast-macros/src/lib.rs |
Updates macro examples and documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were never used in practice (only in tests), and we don't foresee an immediate use for them.
If necessary, we can always add them back later.