Unified: Extract Swift dictionary literals - #22716
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The mapping matches the existing AST schema and is covered by extractor and downstream generated expectations.
Review effort: Balanced
Findings: None
What changed in this PR
Adds structured Swift dictionary literal extraction to the unified AST.
Changes:
- Maps dictionary entries to
key_value_pairchildren ofmap_literal. - Handles empty dictionaries.
- Expands corpus, type-inference, and control-flow coverage.
| File | Description |
|---|---|
unified/extractor/src/languages/swift/swift.rs |
Adds dictionary mapping rules. |
unified/extractor/tests/corpus/swift/collections/dictionary-literal.swift |
Adds dictionary test cases. |
unified/extractor/tests/corpus/swift/collections/dictionary-literal.output |
Updates generated corpus output. |
unified/extractor/tests/corpus/swift/control-flow/switch-expression-pattern.output |
Updates generated nested dictionary AST. |
unified/ql/test/library-tests/type-inference/type-inference.expected |
Records inferred entry types. |
unified/ql/test/library-tests/controlflow/basicblock-slices.expected |
Records entry evaluation flow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps Swift dictionary literals to the existing
map_literalandkey_value_pairin the common AST.