Skip to content

Unified: Join on both name and namespace in derivedStoreReadStep #22717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hvitved wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unified: Join on both name and namespace in derivedStoreReadStep #22717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions unified/ql/lib/codeql/unified/internal/StaticNameBinding.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,14 +335,19 @@ module Track<TrackInputSig Input> {
}
}

pragma[nomagic]
private predicate derivedStoreReadStep0(NamespaceNode namespace, string name, NameBindingNode node2) {
readStep(namespace.ref(), pragma[only_bind_into](name), node2)
}

/**
* Holds if `node1 -> node2` is derived by combining a store and a read step, with zero or more value steps and inheritance steps in-between.
*/
pragma[nomagic]
private predicate derivedStoreReadStep(NameBindingNode node1, NameBindingNode node2) {
exists(NamespaceNode namespace, string name |
node1 = namespace.getMember(pragma[only_bind_into](name)) and // getMember() combines a store step with subsequent inheritance steps
readStep(namespace.ref(), pragma[only_bind_into](name), node2) and
node1 = namespace.getMember(name) and // getMember() combines a store step with subsequent inheritance steps
derivedStoreReadStep0(namespace, name, node2) and
node1 != node2
)
}
Expand Down
Loading