Repository navigation
Drop the 53 declarations GNOME Shell 51 does not have - #155
Merged
Merged
Conversation
Found by check-shell-api and each one confirmed absent from the js/
file at 51.beta, and from the whole js/ tree where the name is unique.
Most were dropped in earlier cycles, so no supported shell has them.
loginManager canSuspend, suspend on both login managers (now in
systemActions)
systemActions _loginManager
altTab onDestroy, init
closeDialog _tracked, _onFocusChanged
components _sessionUpdated
dnd _Draggable pointer and grab handling, fakeRelease,
startDrag (the drag moved to a gesture)
iconGrid _childAdded, _childRemoved
mpris allowed
popupMenu Switch motion and release vfuncs, ignoreRelease
status/* accessibility _buildItemExtended, brightness slider
members, network connectivity helpers, remoteAccess
vfunc_event, thunderbolt _source and _ensureSource
The baseline shrinks to the class and file removals of the next commit.
Three findings were the script's own mistake and are ignored with the
reason: the package's components barrel file, and global and config,
which no js file defines.
Separate from the member removals because this changes what consumers
can import. None of it exists at 51.beta, so an import only moves its
failure from runtime to the compiler.
animation Animation and AnimatedIcon are gone; Spinner is a plain
St.Widget with a constructor, vfunc_map, play and stop
components telepathyClient was dropped upstream ("components: Drop
telepathy client"), with its export in package.json
The baseline is now empty: check-shell-api finds nothing at 51.beta.
This was referenced Oct 6, 2026
JumpLink
marked this pull request as draft
October 6, 2026 09:09
JumpLink
marked this pull request as ready for review
October 6, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #154, so the diff is only the two commits here.
check-shell-api(#154) finds 53 declarations that GNOME Shell 51 no longer has, in 17 modules, 18 of them public. This removes all of them, so the baseline is empty. I checked each one against the upstream source: 29 names appear nowhere injs/at51.beta, and for the other 24 the only hits are in other modules.Commit 1: 39 members
misc/loginManagercanSuspend,suspend(they live insystemActionsnow)misc/systemActions_loginManageraltTabonDestroy,init(upstream:_onDestroy,_init)closeDialog_tracked,_onFocusChangedcomponents_sessionUpdateddnd_Draggable(the drag moved to a gesture)iconGrid_childAdded,_childRemovedmprisallowedpopupMenuSwitchmotion and release vfuncs,ignoreReleasestatus/*accessibility,brightness,network,remoteAccess,thunderbolthelpersCommit 2: classes and a file
Separate because it changes what a consumer can import. None of it exists at
51.beta, so an import only moves its error from runtime to the compiler.animation:AnimationandAnimatedIconare gone.Spinneris a plainSt.Widgetwithplay,stopandvfunc_map.components/telepathyClient: dropped upstream, together with its entry inpackage.json.Not in here
Replacements. Where upstream moved a handler (the
dnddrag, theSwitchvfuncs) the new member is not declared. The script finds what was lost, not what was added.Build, type validation, example and
prettier:checkpass, andcheck:shell-apireports nothing at51.beta.