Repository navigation
Conversation
- as gnome 51 uses this to deal with signal types, manual connect delcarations are deprecated, so this replaces them in this file
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ported my extension to GNOME 51, and found some issues
this is still WIP, as some things need to be refactored in all files, not just the ones, I personally use 😓
Also St-51 has some "invalid types" at least according to docs and https://gjs.guide/extensions/upgrading/gnome-shell-51.html#st-widgets-orientation and https://gnome.pages.gitlab.gnome.org/gnome-shell/st/class.BoxLayout.html#properties there is no vertical property anymore, but the types have it 🤔