fix(mcp): resolve remote find_skills name via tools/list - #26
Merged
Merged
Conversation
The upstream server exposes either find_skills or find_skills_and_tools depending on the rename experiment. Resolve the name once per client from tools/list and call whichever exists, preferring the new name. Co-Authored-By: Claude <noreply@anthropic.com>
aditya-scio
requested review from
david-hamilton-glean,
nikhil-pitta-glean and
steve-calvert-glean
September 17, 2026 21:03
Contributor
Author
|
Old: 
New: 
|
steve-calvert-glean
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_skillsorfind_skills_and_toolsdepending on the rename experiment. The plugin hardcodedfind_skills, so hosts serving the new name broke skill discovery.handleFindSkillsnow lists upstream tools once per client, picks whichever name is present (preferringfind_skills_and_tools), caches it in aWeakMap, and calls that. Falls through to the new name if neither is listed so the upstream error surfaces as before.ponytail:comment: delete the resolver and hardcode the winner once the experiment concludes.Test plan
vitest run --root shared/glean/mcp— 22 files, 336 tests passtools/listcalled once per clienttsc --noEmit -p shared/glean/mcp/tsconfig.jsonclean