Skip to content

fix: use neutral OAuth client name #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eshwar-sundar-glean wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: use neutral OAuth client name #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion shared/glean/mcp/src/auth-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export type InvalidationScope =
| "verifier"
| "discovery";

const OAUTH_CLIENT_NAME = "Glean Enterprise Plugin";

/**
* Open `url` in the user's default browser. Used for the self-open sign-in
* path when the client does not support URL-mode elicitation (where the client
Expand Down Expand Up @@ -79,7 +81,7 @@ export class GleanOAuthClientProvider implements OAuthClientProvider {
get clientMetadata(): OAuthClientMetadata {
return {
redirect_uris: [getCallbackUrl()],
client_name: "Glean Claude Code Plugin",
client_name: OAUTH_CLIENT_NAME,
};
}

Expand Down
2 changes: 1 addition & 1 deletion shared/glean/mcp/tests/auth-provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe("GleanOAuthClientProvider", () => {
it("clientMetadata includes redirect URI and client name", () => {
const provider = new GleanOAuthClientProvider();
const meta = provider.clientMetadata;
expect(meta.client_name).toBe("Glean Claude Code Plugin");
expect(meta.client_name).toBe("Glean Enterprise Plugin");
expect(meta.redirect_uris).toHaveLength(1);
expect(meta.redirect_uris![0]).toMatch(/127\.0\.0\.1/);
});
Expand Down
Loading