allow to pass value as props #34

Activity

1. rxaviers commented on Dec 16, 2015

   

   rxaviers

   on Dec 16, 2015

   Member

   More actions

   Hi,

   Currently, whatever is passed in value gets overwritten by children (code below). We could change the below for not overwritten args[0] if children is falsy. so we enable both usages in your description.

   // src/generator.js:
   this.args[0] = this.props.children;

   Would you like to submit a pull request with such change?
2. fdecampredon commented on Dec 16, 2015

   

   fdecampredon

   on Dec 16, 2015

   Author

   More actions

   I'll do so !
3. kborchers commented on Mar 11, 2016

   

   kborchers

   on Mar 11, 2016

   Collaborator

   More actions

   Hi @fdecampredon. Are you still interested in working on this?
4. cowboy commented on Mar 11, 2016

   

   cowboy

   on Mar 11, 2016

   More actions

   I had the same question. I'd love to see this implemented. Basically, use this.props.value if set, otherwise use this.props.children.
5. gnarf commented on Mar 11, 2016

   

   gnarf

   on Mar 11, 2016

   More actions

   I actually think that you should only allow value= prop and deprecate the children format.
6. cowboy commented on Mar 11, 2016

   

   cowboy

   on Mar 11, 2016

   More actions

   I actually think that you should only allow value= prop and deprecate the children format.

   👍 to that
7. rxaviers commented on Mar 15, 2016

   

   rxaviers

   on Mar 15, 2016

   Member

   More actions

   @gnarf I see you have a preference, but the motivation isn't clear to me. Using a value attribute instead of children might be convenient in the given example (I agree), but using the opposite (children instead of a value attribute) might be convenient in other cases like:

   <FormatMessage>You’re receiving notifications because you commented</FormatMessage>

   I hold my preference for "use this.props.value if set, otherwise use this.props.children". I don't see any problem with allowing both options this way.

   PRs are still very welcome. Thanks
8. kborchers commented on Mar 15, 2016

   

   kborchers

   on Mar 15, 2016

   Collaborator

   More actions

   I agree with @rxaviers here. I am working on adding some initial tests to the repo (PR almost ready) and then I will add this "use this.props.value if set, otherwise use this.props.children" functionality along with additional tests
9. kborchers

   added a commit that references this issue on Mar 16, 2016

   Add ability to use value prop and fall back to children

   ...

   This issue will close once commit 92eadf2 is merged into the 'master' branch.

   92eadf2