Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
# db — `gddy db` commands
rust/src/db/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy @daleksic-godaddy @dcanic-godaddy @mcolakovic-godaddy

# dns — TODO: get list of reviewers for DNS
rust/src/dns/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy
# dns — gddy dns commands
rust/src/dns/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy @jmunson-godaddy @bdittmer-godaddy

# domains — TODO: get list of reviewers for domains
rust/domains-client/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy
rust/src/domain/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy
# domains — gddy domain commands
rust/domains-client/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy @jmunson-godaddy @bdittmer-godaddy
rust/src/domain/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy @jmunson-godaddy @bdittmer-godaddy

# email — gddy email commands
rust/email-client/** @axburgess-godaddy @jpage-godaddy @jpearlman-godaddy @mguerrero3-godaddy @qcai-godaddy @rts1-godaddy @runruh-godaddy @sgimpel-godaddy @srao-godaddy
Expand Down
8 changes: 4 additions & 4 deletions .github/scripts/reviewers.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@
"users": ["daleksic-godaddy", "dcanic-godaddy", "mcolakovic-godaddy"]
},
{
"comment": "TODO: get list of reviewers for DNS",
"comment": "gddy dns commands",
"label": "dns",
"patterns": ["rust/src/dns/**"],
"users": []
"users": ["jmunson-godaddy", "bdittmer-godaddy"]
},
{
"comment": "TODO: get list of reviewers for domains",
"comment": "gddy domain commands",
"label": "domains",
"patterns": ["rust/domains-client/**", "rust/src/domain/**"],
"users": []
"users": ["jmunson-godaddy", "bdittmer-godaddy"]
},
{
"comment": "gddy email commands",
Expand Down
2 changes: 2 additions & 0 deletions rust/src/dns/guides/dns.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ gddy dns delete example.com --type A --name www

Deleting something that doesn't match is a no-op success (`deleted: 0`), not an error. Preview with `--dry-run` first for anything you're not fully sure about.

For `SRV` and `TLSA` records, the name does not include the service or port: `--type SRV --name chat` matches every SRV record listed under `chat`, whatever its service, so `list` or `--dry-run` first to see which will be removed. To target one service, give the full name instead, e.g. `--name _sip._tcp.chat` (for `TLSA`, `_443._tcp.www`).

## International domain names

Domain names and record names can be typed either as Unicode (`münchen.de`) or in their encoded form (`xn--mnchen-3ya.de`); both reach the same domain. Output shows Unicode by default. Add `--punycode` to any DNS command to show the encoded form instead, or make that your default with `gddy config set punycode true` (undo it with `gddy config unset punycode`). Precedence is the `--punycode` flag, then the `GDDY_PUNYCODE` environment variable, then your saved setting, then Unicode, so `--punycode=false` turns the encoded form back off for one command. `gddy config list` shows the current value. Record values (the `--data` of a CNAME, MX or TXT record) are never converted; enter them exactly as they should be stored.
Expand Down
Loading
Loading