Skip to content

fix(release): sign the Windows gddy.exe - #378

Merged
jpage-godaddy merged 2 commits into
mainfrom
windows-signing
Nov 16, 2026
Merged

jpage-godaddy merged 2 commits into
mainfrom
windows-signing

Conversation

@jpage-godaddy

@jpage-godaddy jpage-godaddy commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

The Windows gddy.exe in each release is now code-signed, and the signature is verified before the binary is packaged into the release zip.

🤖 Generated with Claude Code

The Windows gddy.exe in each release is now Authenticode-signed, so
SmartScreen shows the publisher name and managed machines that require
signed executables can run it. The signature is verified before the
binary is packaged.

Signing uses DigiCert's official GitHub Action, pinned to a commit SHA,
and replaces the hand-rolled PowerShell script.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The pinned DigiCert action could not be inspected, and credential-log safety plus end-to-end Windows release signing and signature verification still require validation on a credentialed runner.

No open issues 🎉

What changed in this PR

Adds opt-in Authenticode signing for Windows release binaries using DigiCert KeyLocker, replacing the scaffolded PowerShell script with an official action pinned to a commit SHA.

Changes:

  • Enables signing when ENABLE_WINDOWS_SIGNING is 1.
  • Prepares the client certificate and cleans it up even if signing fails.
  • Verifies the executable’s signature before packaging, blocking release on signing or verification failure.
File Description
.github/​workflows/​Sign-WithKeyLocker.ps1 Removes the standalone signing script.
.github/​workflows/​release.yml Adds gated certificate preparation, signing, verification, and cleanup steps.

Review effort: Balanced

@jpage-godaddy jpage-godaddy changed the title fix(release): sign the Windows gddy.exe with DigiCert KeyLocker fix(release): sign the Windows gddy.exe Nov 16, 2026
Comment thread .github/workflows/release.yml Resolved
Check every secret and variable the Windows signing steps need before
using them, and name the ones that are missing. A missing or malformed
client certificate now fails with a specific error instead of surfacing
later inside the base64 decode or the signing action.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The pinned DigiCert action could not be inspected, and the credentialed Windows release flow remains unvalidated for executable signing, signature verification, and credential-safe logging.

No open issues 🎉

Review effort: Balanced

@jpage-godaddy
jpage-godaddy merged commit 34d5a09 into main Nov 16, 2026
7 checks passed
@jpage-godaddy
jpage-godaddy deleted the windows-signing branch November 16, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants