Repository navigation
fix(release): sign the Windows gddy.exe - #378
Merged
Merged
Conversation
The Windows gddy.exe in each release is now Authenticode-signed, so SmartScreen shows the publisher name and managed machines that require signed executables can run it. The signature is verified before the binary is packaged. Signing uses DigiCert's official GitHub Action, pinned to a commit SHA, and replaces the hand-rolled PowerShell script. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jpage-godaddy
requested review from
axburgess-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy and
rts1-godaddy
as code owners
November 16, 2026 20:59
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The pinned DigiCert action could not be inspected, and credential-log safety plus end-to-end Windows release signing and signature verification still require validation on a credentialed runner.
No open issues 🎉
What changed in this PR
Adds opt-in Authenticode signing for Windows release binaries using DigiCert KeyLocker, replacing the scaffolded PowerShell script with an official action pinned to a commit SHA.
Changes:
- Enables signing when
ENABLE_WINDOWS_SIGNINGis1. - Prepares the client certificate and cleans it up even if signing fails.
- Verifies the executable’s signature before packaging, blocking release on signing or verification failure.
| File | Description |
|---|---|
.github/workflows/Sign-WithKeyLocker.ps1 |
Removes the standalone signing script. |
.github/workflows/release.yml |
Adds gated certificate preparation, signing, verification, and cleanup steps. |
Review effort: Balanced
rts1-godaddy
approved these changes
Nov 16, 2026
Check every secret and variable the Windows signing steps need before using them, and name the ones that are missing. A missing or malformed client certificate now fails with a specific error instead of surfacing later inside the base64 decode or the signing action. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The pinned DigiCert action could not be inspected, and the credentialed Windows release flow remains unvalidated for executable signing, signature verification, and credential-safe logging.
No open issues 🎉
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows
gddy.exein each release is now code-signed, and the signature is verified before the binary is packaged into the release zip.🤖 Generated with Claude Code