Repository navigation
feat(dns): show priority, port, service and protocol in listings, delete previews and set results - #379
Open
jpage-godaddy wants to merge 2 commits into
Open
feat(dns): show priority, port, service and protocol in listings, delete previews and set results#379jpage-godaddy wants to merge 2 commits into
jpage-godaddy wants to merge 2 commits into
Conversation
…ete previews and set results SRV records under one name used to look identical in `dns list`, in the preview `dns delete --dry-run` prints, and in the records `dns set` reports: three services showed the same type, name, data and TTL, so there was no telling which one a delete would remove. The columns that tell them apart now appear: - `dns list` adds Priority, Weight, Port, Service, Protocol, Flag, Tag and Parameters, each only when a listed record has a value for it. A listing of A, TXT and CNAME records looks exactly as before; an MX record adds Priority, a CAA record adds Flag and Tag, an SRV record adds the SRV columns. - `dns delete --dry-run` and the result of `dns set` show the same columns for the records they list. - JSON output gains those fields on the records that have them. `set` and `delete` no longer print an empty `Records:` or `Plan:` line for the section a result doesn't carry (a real `set` has no plan, a `--dry-run` has no records, a `delete` that matched nothing has no records). Updates cli-engine to 0.10.6, which provides both behaviours. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jpage-godaddy
requested review from
axburgess-godaddy,
bdittmer-godaddy,
jmunson-godaddy,
jpearlman-godaddy,
mguerrero3-godaddy,
qcai-godaddy and
rts1-godaddy
as code owners
November 16, 2026 21:37
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
TLSA delete previews omit usage, selector, and matchingType, leaving distinct records indistinguishable apart from IDs; use merged_tlsa_data and add coverage with populated numeric fields.
1 open issue
What changed in this PR
This PR makes type-specific DNS records easier to distinguish in listings, delete previews, and set results, building on the record reporting introduced in #359.
Changes:
- Shares optional record-detail columns across DNS outputs, showing them only when populated.
- Hides empty Records and Plan sections using cli-engine 0.10.6.
- Adds rendering and field-consistency tests and clarifies underscore formatting in the guide.
| File | Description |
|---|---|
rust/src/dns/set/outcome.rs |
Tests SRV detail rendering and plain-record output. |
rust/src/dns/set/mod.rs |
Adds shared detail columns and hides empty result sections. |
rust/src/dns/records.rs |
Defines shared detail fields, columns, and value extraction. |
rust/src/dns/records_tests.rs |
Tests detail-field consistency and extraction. |
rust/src/dns/list.rs |
Expands default columns and tests conditional rendering. |
rust/src/dns/guides/dns.md |
Clarifies underscore formatting in listings. |
rust/src/dns/delete.rs |
Adds record details to delete previews and rendering tests. |
rust/Cargo.toml |
Raises the cli-engine requirement to 0.10.6. |
rust/Cargo.lock |
Updates cli-engine and Windows dependency references. |
Review effort: Balanced
…elete previews `dns delete --dry-run` and the per-record results of a real delete labelled a TLSA record by its certificate alone. Two records that share a certificate, port and protocol but differ in usage, selector or matching type looked identical, and a delete by name removes every one of them. They are now labelled the way `dns list` shows them: usage, selector, matching type, then the certificate. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes for users
SRV records under one name used to look identical wherever
gddylisted them. Three services atchatshowed the same type, name, data and TTL indns list, in the previewdns delete --dry-runprints, and in the recordsdns setreports, so there was no telling which one a delete would remove.The columns that tell them apart now appear, only when a listed record has a value for them:
dns listdns delete --dry-rundns setresultAn MX record adds Priority; a CAA record adds Flag and Tag; HTTPS and SVCB records add Parameters. TLSA records add no extra columns, because their data already carries usage, selector, matching type and certificate. The delete preview and the per-record results of a real delete label TLSA records the same way, so two that differ only in usage or matching type can be told apart before a delete removes them. JSON output gains the same fields on the records that have them.
setanddeletealso no longer print an emptyRecords:orPlan:line for the section a result doesn't carry. A realsethas no plan, a--dry-runhas no records, and adeletethat matched nothing has no records.Under the hood
hide_when_emptyfor the optional columns and for the nestedrecordsandplansections. It needs cli-engine 0.10.6, which provides both (cli-engine feat(paas): add GitHub operations for Node.js Hosting CLI command group #135 for tables of rows, feat(application init): gate creation on onboarding (DEVX-545) #139 for single-object results), so this updates the requirement from 0.10.4 to 0.10.6.records.rsand shared bylist, the delete preview and the set result, and a test fails if they drift apart.Cargo.lockchanges only as cargo's own consequence of that bump: I re-derived it from fix(dns): replace records in place with dns set and confirm the final result #359's lockfile withcargo update -p cli-engineand got the identical result. Besidescli-engineitself, the other changed lines arewindows-sysedges from the engine's own dependency tree.Verification
cargo check --workspace,cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --check,cargo test --workspace(1283 tests in the main crate) and./rust/scripts/check-module-size.shall pass, against the published cli-engine 0.10.6 with no local patch.delete --dry-runon those three services lists each by service and port before anything is removed;set(real and--dry-run),delete --dry-runand a no-matchdeleteprint no blankRecords:orPlan:line, and their real nested tables are still there.--type SRVor--fieldsavoids it.🤖 Generated with Claude Code