Repository navigation
fix(ring): serialize capacity and shutdown checks - #176
Merged
Merged
Conversation
appleboy
approved these changes
Oct 31, 2026
Member
|
@bensynapse Thanks. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 91.29% 92.73% +1.44%
==========================================
Files 7 8 +1
Lines 402 413 +11
==========================================
+ Hits 367 383 +16
- Misses 28 30 +2
+ Partials 7 0 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
WithQueueSize(2)can admit four jobs when producers submit at the same time.Ring.Queuechecks capacity before locking the buffer.Ring.Requestalso readscountwithout locking during shutdown. Concurrent readers can trigger a data race and returnErrNoTaskInQueueafter closure.Move both checks inside the existing mutex so they share the lock with buffer updates. Add concurrent capacity and shutdown drain tests.
make testpasses with race detection on Go 1.26.8 and 1.27.0. The focused regressions pass 50 runs with-race.make lint,go build ./...andgo vet ./...pass. Both example modules build and execute successfully.