Conversation
The qemu_cli VMM only wired up the kernel's vhost-vsock device, so
run_cvd's vsock servers fail in containers without AF_VSOCK. Emit a
vhost-user-vsock-pci-non-transitional device backed by vhost_device_vsock
instead. `auto` now keys off the guest target_arch and covers arm64 and
riscv64, so x86_64 hosts running arm64 guests under qemu_cli switch to
vhost-user vsock.
QEMU connects to the chardev once at startup instead of retrying like
crosvm, so wait for vhost.socket to listen first. That wait reads
/proc/net/unix instead of lsof, and must not connect: the backend would
consume the probe as its one allowed frontend.
Bug: b/561671404
Test: cvd start --vm_manager=qemu_cli --vhost_user_vsock=true, for an
x86_64 guest on an x86_64 host and an arm64 guest on an x86_64
host. Both reach sys.boot_completed=1 with adb working over vsock.
Member
That was the original motivation for using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The qemu_cli VMM only wired up the kernel's vhost-vsock device, so run_cvd's vsock servers fail in containers without AF_VSOCK. Emit a vhost-user-vsock-pci-non-transitional device backed by vhost_device_vsock instead.
autonow keys off the guest target_arch and covers arm64 and riscv64, so x86_64 hosts running arm64 guests under qemu_cli switch to vhost-user vsock.QEMU connects to the chardev once at startup instead of retrying like crosvm, so wait for vhost.socket to listen first. That wait reads /proc/net/unix instead of lsof, and must not connect: the backend would consume the probe as its one allowed frontend.
Bug: b/561671404
Test: cvd start --vm_manager=qemu_cli --vhost_user_vsock=true, for an
x86_64 guest on an x86_64 host and an arm64 guest on an x86_64
host. Both reach sys.boot_completed=1 with adb working over vsock.