Repository navigation
Update Benchmark to 1.10.0 - #16306
Merged
Merged
Conversation
With `-Werror=thread-safety` and an annotated libc++, Clang rejects Benchmark's mutex wrapper: it sees the acquisition inside `Mutex::lock()` but cannot tell that the caller receives the lock. Use Benchmark 1.10.0, which annotates the wrapper when compiling with Clang [1]. [1]: google/benchmark@82a895089
copybara-service
Bot
force-pushed
the
test/cl1006077549
branch
2 times, most recently
from
October 24, 2026 05:59
b26cc2f to
0172803
Compare
PiperOrigin-RevId: 1006115873
copybara-service
Bot
force-pushed
the
test/cl1006077549
branch
from
October 24, 2026 06:03
0172803 to
bd4908a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Benchmark to 1.10.0
With
-Werror=thread-safetyand an annotated libc++, Clang rejectsBenchmark's mutex wrapper: it sees the acquisition inside
Mutex::lock()but cannot tell that the caller receives the lock.Use Benchmark 1.10.0, which annotates the wrapper when compiling with
Clang 1.
Auto-fixed-by: [🤖] @EtiennePerot
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15376 from tamird:benchmark-thread-safety-current adf6f31