Repository navigation
Declare image contexts and CUDA helper builds - #16308
Merged
Merged
Conversation
CUDA test images compiled their sample runners with a separate Go 1.25 Docker stage. The runners were outside Bazel's Go build and analysis graph, and repository SDK upgrades did not update their compiler. Build both runners with the repository SDK and package their static binaries with the image sources. Stage that architecture-selected context before Make hashes or builds either CUDA image, so helper and SDK changes invalidate the image cache. The archive also supplies declared inputs for remote image builds without invoking Bazel from inside a build action. Analyzing these programs also exposes a recursive mutex acquisition in one runner: ExitCode called Done while holding the mutex that Done takes. Release the lock before waiting, as the other runner already does, and update both programs to satisfy the newly enabled analyzer checks. The ASCII image converter continues to use its separate Go Docker stage. Assisted-by: OpenAI Codex
PiperOrigin-RevId: 1006153451
copybara-service
Bot
force-pushed
the
test/cl1003651532
branch
from
October 24, 2026 07:44
d9af6e7 to
d15d531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare image contexts and CUDA helper builds
CUDA test images compiled their sample runners with a separate Go 1.25
Docker stage. The runners were outside Bazel's Go build and analysis
graph, and repository SDK upgrades did not update their compiler.
Build both runners with the repository SDK and package their static
binaries with the image sources. Stage that architecture-selected
context before Make hashes or builds either CUDA image, so helper and
SDK changes invalidate the image cache. The archive also supplies
declared inputs for remote image builds without invoking Bazel from
inside a build action.
Analyzing these programs also exposes a recursive mutex acquisition in
one runner: ExitCode called Done while holding the mutex that Done
takes. Release the lock before waiting, as the other runner already
does, and update both programs to satisfy the newly enabled analyzer
checks.
The ASCII image converter continues to use its separate Go Docker stage.
Assisted-by: OpenAI Codex
Auto-fixed-by: [🤖] @EtiennePerot
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15670 from tamird:cuda-image-contexts 923b3b3