Repository navigation
Conversation
mfield4
force-pushed
the
tlvtool-graft
branch
from
November 9, 2026 19:59
ab475b1 to
7e6daa9
Compare
mfield4
force-pushed
the
tlvtool-graft
branch
from
November 10, 2026 00:12
7e6daa9 to
c2a260a
Compare
An error occurred while trying to automatically change base from
mutask-graft-cleanup
to
mutask-graft
November 10, 2026 00:37
mfield4
marked this pull request as ready for review
November 10, 2026 00:42
mfield4
force-pushed
the
tlvtool-graft
branch
4 times, most recently
from
November 13, 2026 19:28
989d4e5 to
74ef727
Compare
Build each record through the public builder API and compare the whole inspect report to a committed golden file. This covers byte offsets, word counts, padding and the shape of the tree, none of which a search for tag names can check. Regenerate with: UPDATE_GOLDEN=1 bazel run //tlvtool/tests:inspect_test
tlvtool joins the other host tools under tools/. Point it at the TLV libraries in shared/ and their openprot_* crate and proto names, and find the binary under the main repository (_main) in runfiles.
mfield4
force-pushed
the
tlvtool-graft
branch
from
November 13, 2026 19:46
74ef727 to
c1866c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 3 (#324, #327, #328).
This PR imports
tlvtool(a host tool for building, signing, and inspecting TLV records like key rotation records) from mutask with its commit history intact, and moves it totools/tlvtool.Please merge with "Rebase and merge" (not squash) to keep the imported commit history. The imported commits still use the pre-#327 crate names and paths, so only the PR head builds.
What to review
Commits 1-6 are imported history from mutask with original author, dates, and commit messages preserved. They were already reviewed in mutask, so there's no need to review them line by line.
Commit 7 (
tlvtool: Build in libhoth under tools/tlvtool) is the only new commit in libhoth. It movestlvtool/totools/tlvtool/, updates labels and crate/proto names to//shared/...andopenprot_*from #327, and looks up the binary under_mainin runfiles.Note that
tlvtool krr signcurrently attaches signatures without verifying them; verification depends on the vendored PQC library mentioned in #327 and will be added when that lands.History import
This uses the same filter pass from
contrib/libhoth_graft/as #327: filtering totlvtool/, scrubbing internal names and comments, strippingChange-Id:andBug:footers, and adding Apache-2.0 headers. The public keys embedded insrc/crypto.rsandtests/cli_test.rsare test keys.Googlers with mutask access can verify commits 1-6 from the same
/tmp/libhoth-graftcheckout used in #327: