Preserve frame pointers in the generated CMake build (#4) - #1010
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
absl::GetStackTrace() selects stacktrace_x86-inl.inc on Linux/x86-64 (and the analogous aarch64 backend on ARM), both of which walk the frame-pointer chain. The unwind begins inside Abseil's own UnwindImpl(), so omitting frame pointers anywhere in the process -- including in libabsl_stacktrace.a -- causes every unwind to return zero frames. The generated CMake build inherited the compiler default (frame pointers omitted at -O1 and above), so TCMalloc recorded empty stacks for every sampled allocation. Inside google3 this is masked: -fno-omit-frame-pointer is part of the default toolchain copts, so it never appears in copts.bzl and thus never reaches the CMake translation. Emit add_compile_options(-fno-omit-frame-pointer) in the top-level CMakeLists.txt ahead of the FetchContent calls so the dependencies pick it up as well. PiperOrigin-RevId: 983929699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve frame pointers in the generated CMake build (#4)
absl::GetStackTrace() selects stacktrace_x86-inl.inc on Linux/x86-64 (and the
analogous aarch64 backend on ARM), both of which walk the frame-pointer chain.
The unwind begins inside Abseil's own UnwindImpl(), so omitting frame pointers
anywhere in the process -- including in libabsl_stacktrace.a -- causes every
unwind to return zero frames.
The generated CMake build inherited the compiler default (frame pointers
omitted at -O1 and above), so TCMalloc recorded empty stacks for every sampled
allocation. Inside google3 this is masked: -fno-omit-frame-pointer is part of
the default toolchain copts, so it never appears in copts.bzl and thus never
reaches the CMake translation.
Emit add_compile_options(-fno-omit-frame-pointer) in the top-level
CMakeLists.txt ahead of the FetchContent calls so the dependencies pick it up
as well.