Eliminate harness measurement distortion in TransferCache benchmarks. - #1022
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
BM_InsertRange, BM_RemoveRange, BM_RealisticBatchNonBatchMutations, and BM_RealisticHitRate in transfer_cache_benchmark invoked state.PauseTiming() and state.ResumeTiming() inside every iteration of the benchmark loop, spending ~60% of CPU cycles in clock_gettime/vDSO syscall overhead (~1300 ns/iter) and obscuring the underlying 10-30 ns cache operations. In addition, FakeTransferCacheEnvironment::Insert and Remove allocated temporary std::vector instances on the heap in each call. Amortize setup across batches with state.KeepRunningBatch in BM_InsertRange and BM_RemoveRange, precompute PRNG decisions in BM_RealisticBatchNonBatchMutations and BM_RealisticHitRate, and replace dynamic std::vector buffers with stack arrays in FakeTransferCacheEnvironment. Also: - Fix mincore_benchmark invalid address (NULL) and double page size multiplication bug in memory offset calculations. - Add size classes 128 B and 256 B to BM_new_delete_fixed in tcmalloc_benchmark. - Use sized deallocation MockSpan::Delete in linked_list_benchmark. PiperOrigin-RevId: 984204084
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate harness measurement distortion in TransferCache benchmarks.
BM_InsertRange, BM_RemoveRange, BM_RealisticBatchNonBatchMutations, and
BM_RealisticHitRate in transfer_cache_benchmark invoked state.PauseTiming()
and state.ResumeTiming() inside every iteration of the benchmark loop,
spending ~60% of CPU cycles in clock_gettime/vDSO syscall overhead (~1300 ns/iter)
and obscuring the underlying 10-30 ns cache operations. In addition,
FakeTransferCacheEnvironment::Insert and Remove allocated temporary std::vector
instances on the heap in each call.
Amortize setup across batches with state.KeepRunningBatch in BM_InsertRange and
BM_RemoveRange, precompute PRNG decisions in BM_RealisticBatchNonBatchMutations
and BM_RealisticHitRate, and replace dynamic std::vector buffers with stack
arrays in FakeTransferCacheEnvironment.
Also:
multiplication bug in memory offset calculations.