Fix address and stride calculation bug in mincore_benchmark. - #1023
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
mincore was called with invalid memory address 0 (NULL), causing every syscall to return ENOMEM (-1). In addition, length was already in bytes (size * kHardwarePageSize), so advancing memory += length * kHardwarePageSize caused a double-multiplication error that skipped 1 GiB on the first step for size >= 64. Allocate an anonymous mmap region and advance the scan offset by length. PiperOrigin-RevId: 984208847
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix address and stride calculation bug in mincore_benchmark.
mincore was called with invalid memory address 0 (NULL), causing every syscall
to return ENOMEM (-1). In addition, length was already in bytes (size * kHardwarePageSize),
so advancing memory += length * kHardwarePageSize caused a double-multiplication
error that skipped 1 GiB on the first step for size >= 64.
Allocate an anonymous mmap region and advance the scan offset by length.