Refactor Static to have non-static fields - #936
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_982476163
branch
8 times, most recently
from
September 21, 2026 15:37
b41ea67 to
05fa209
Compare
Make all Static class fields non-static and define a constexpr constructor for Static. This removes the need for duplicate field definitions in static_vars.cc and simplifies metadata_bytes() calculation to sizeof(*this). PiperOrigin-RevId: 985306822
copybara-service
Bot
force-pushed
the
test_982476163
branch
from
September 21, 2026 15:51
05fa209 to
fef3235
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Static to have non-static fields
Make all Static class fields non-static and define a constexpr constructor
for Static. This removes the need for duplicate field definitions
in static_vars.cc and simplifies metadata_bytes() calculation to sizeof(*this).