Skip to content

Normalize UI diagnostics using the selected compiler sysroot - #3740

Closed
joshlf wants to merge 4 commits into
Gxi6wprpgshggdrhvt64jphmjwhociog5from
Gzdelmzn5y42ab3htat7lqrwovbusi5sh
Closed

joshlf wants to merge 4 commits into
Gxi6wprpgshggdrhvt64jphmjwhociog5from
Gzdelmzn5y42ab3htat7lqrwovbusi5sh

Conversation

@joshlf

@joshlf joshlf commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Use the compiler's actual sysroot, including custom RUSTUP_HOME installations, when normalizing source paths. Replace the broad path regex, which could consume preceding diagnostic lines, with exact path matching. Regenerate the affected MSRV, stable, and nightly snapshots through the UI runner.

gherrit-pr-id: Gzdelmzn5y42ab3htat7lqrwovbusi5sh
Validation: UI snapshot generation on MSRV, stable, and nightly; nightly workspace UI replay.


Latest Update: v5 — Compare vs v4

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v4 v3 v2 v1 Base
v5 vs v4 vs v3 vs v2 vs v1 vs Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gzdelmzn5y42ab3htat7lqrwovbusi5sh && git checkout -b pr-Gzdelmzn5y42ab3htat7lqrwovbusi5sh FETCH_HEAD

Checkout

git fetch origin refs/heads/Gzdelmzn5y42ab3htat7lqrwovbusi5sh && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gzdelmzn5y42ab3htat7lqrwovbusi5sh && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gzdelmzn5y42ab3htat7lqrwovbusi5sh

Stacked PRs enabled by GHerrit.

gherrit-pr-id: Gf75ukj4vvtufg6dwjpfa3bx5a457sw74
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T07:37:16.032878Z 10ce2c7 PR opened
🔒 Security Review ✅ Completed 2026-10-02T07:36:19.232482Z 10ce2c7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (fec742a) to head (f7e72dc).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           Gxi6wprpgshggdrhvt64jphmjwhociog5    #3740   +/-   ##
==================================================================
  Coverage                              91.90%   91.90%           
==================================================================
  Files                                     20       20           
  Lines                                   6177     6177           
==================================================================
  Hits                                    5677     5677           
  Misses                                   500      500           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add a contract command for total Aeneas specifications and an explicit partial
variant. Migrate the four existing inline proofs without changing their
preconditions or postconditions: padding and round-down retain their original
proof bodies, and min/max reuse their existential proofs through a WP adapter.

Check macro quantifiers, tuple binders, panic, and divergence against independent
propositions. Recognize contract declarations in inline tooling and retain the
independent required-type checks against both golden and live models.

Validation: fresh extraction and both Lean model builds and axiom audits, 15
Python tests, two Rust parser tests, 16 negative controls, and repository
pre-push checks passed.

gherrit-pr-id: Gmasez6fvx2c6chogoybuzpgyoykiaupc
Agent-authored-by: AI agent acting on joshlf's behalf
@joshlf
joshlf force-pushed the Gzdelmzn5y42ab3htat7lqrwovbusi5sh branch from 10ce2c7 to a2024a1 Compare October 2, 2026 13:43
@joshlf
joshlf force-pushed the Gmasez6fvx2c6chogoybuzpgyoykiaupc branch from 9be4908 to 83ba7cd Compare October 2, 2026 13:43
@joshlf
joshlf changed the base branch from Gmasez6fvx2c6chogoybuzpgyoykiaupc to Gxi6wprpgshggdrhvt64jphmjwhociog5 October 2, 2026 13:43
joshlf added 2 commits October 2, 2026 10:23
Specify exact padding and round-down results, their extremal properties, and
min/max membership and bounds. Factor the arithmetic into reusable lemmas and
prove that layout padding preserves alignment and the shallow-padding flag.

Support inline proofs on inherent methods, order caller proofs by declared
callee dependencies, and audit those dependencies after elaboration. Keep
independent required propositions and add mutation controls for the stronger
claims against both golden and freshly extracted models.

Validation: golden/live Lean checks, negative controls, inline tooling tests,
and repository pre-push checks passed.

gherrit-pr-id: Gxi6wprpgshggdrhvt64jphmjwhociog5
Agent-authored-by: AI agent acting on joshlf's behalf
Use the compiler's actual sysroot, including custom RUSTUP_HOME installations, when normalizing source paths. Replace the broad path regex, which could consume preceding diagnostic lines, with exact path matching. Regenerate the affected MSRV, stable, and nightly snapshots through the UI runner.

gherrit-pr-id: Gzdelmzn5y42ab3htat7lqrwovbusi5sh
Validation: UI snapshot generation on MSRV, stable, and nightly; nightly workspace UI replay.
@joshlf
joshlf force-pushed the Gxi6wprpgshggdrhvt64jphmjwhociog5 branch from 35cfc20 to b5d25f5 Compare October 3, 2026 16:09
@joshlf joshlf closed this Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants