Skip to content

Normalize compiler paths and implementation samples in UI diagnostics - #3769

Merged
joshlf merged 1 commit into
mainfrom
G5hs7ombjwaxa43hlvraivt7tlmqscvmr
Oct 2, 2026
Merged

joshlf merged 1 commit into
mainfrom
G5hs7ombjwaxa43hlvraivt7tlmqscvmr

Conversation

@joshlf

@joshlf joshlf commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Use the compiler's actual sysroot, including custom RUSTUP_HOME installations, and match it exactly so path normalization preserves neighboring diagnostic lines. Normalize rustc's arbitrary truncated implementation samples while preserving the trait header, complete lists, and specific implementation advice.

Regenerate the affected snapshots through the MSRV, stable, and nightly UI runners. Focused normalizer tests check portable samples and preservation of errors, source spans, trait names, and other advice.

Validation: official UI runners on MSRV, stable, and nightly; normalizer unit tests and nightly Clippy.
Authored by an AI agent acting on joshlf's behalf.


Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v1 Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/G5hs7ombjwaxa43hlvraivt7tlmqscvmr && git checkout -b pr-G5hs7ombjwaxa43hlvraivt7tlmqscvmr FETCH_HEAD

Checkout

git fetch origin refs/heads/G5hs7ombjwaxa43hlvraivt7tlmqscvmr && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/G5hs7ombjwaxa43hlvraivt7tlmqscvmr && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/G5hs7ombjwaxa43hlvraivt7tlmqscvmr

Stacked PRs enabled by GHerrit.

Use the compiler's actual sysroot, including custom RUSTUP_HOME installations, and match it exactly so path normalization preserves neighboring diagnostic lines. Normalize rustc's arbitrary truncated implementation samples while preserving the trait header, complete lists, and specific implementation advice.

Regenerate the affected snapshots through the MSRV, stable, and nightly UI runners. Focused normalizer tests check portable samples and preservation of errors, source spans, trait names, and other advice.

gherrit-pr-id: G5hs7ombjwaxa43hlvraivt7tlmqscvmr
Validation: official UI runners on MSRV, stable, and nightly; normalizer unit tests and nightly Clippy.
Agent-authored-by: AI agent acting on joshlf's behalf
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T19:43:13.416445Z 7eb7f6d PR opened
🔒 Security Review ✅ Completed 2026-10-02T19:42:51.404413Z 7eb7f6d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.16%. Comparing base (a2f0fa2) to head (3be4429).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3769   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files          16       16           
  Lines        2413     2413           
=======================================
  Hits         2248     2248           
  Misses        165      165           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf changed the title Normalize UI diagnostics using the selected compiler sysroot Normalize compiler paths and implementation samples in UI diagnostics Oct 2, 2026
@joshlf
joshlf force-pushed the G5hs7ombjwaxa43hlvraivt7tlmqscvmr branch from 7eb7f6d to 3be4429 Compare October 2, 2026 21:06
@joshlf
joshlf enabled auto-merge October 2, 2026 21:07
@joshlf
joshlf added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit 79a3578 Oct 2, 2026
110 checks passed
@joshlf
joshlf deleted the G5hs7ombjwaxa43hlvraivt7tlmqscvmr branch October 2, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants